commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEANUTILS-439) Save Logger in static filed in MethodUtils instead of requesting it on every method invocation
Date Mon, 06 May 2013 09:48:16 GMT

    [ https://issues.apache.org/jira/browse/BEANUTILS-439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13649630#comment-13649630
] 

Sebb commented on BEANUTILS-439:
--------------------------------

Sorry, don't have docs to hand. It was not me that raised the issue originally.

I mean that the logger should be cached in the instance. Perhaps a volatile field.

But I agree the easiest is to avoid all these problems by leaving logging to the calling code.
In general it should not be necessary to log in low level libraries.
                
> Save Logger in static filed in MethodUtils instead of requesting it on every method invocation
> ----------------------------------------------------------------------------------------------
>
>                 Key: BEANUTILS-439
>                 URL: https://issues.apache.org/jira/browse/BEANUTILS-439
>             Project: Commons BeanUtils
>          Issue Type: Improvement
>          Components: Bean / Property Utils
>    Affects Versions: 1.8.3
>            Reporter: Benedikt Ritter
>            Assignee: Benedikt Ritter
>              Labels: logging, performance
>             Fix For: 1.8.4
>
>
> It was proposed on the ML to create a static field reference to the Logger in MethodUtils,
because requesting it on every method invocation leads to bad performance (see http://markmail.org/message/ysurofedfoikdguu).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message