commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benedikt Ritter (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEANUTILS-439) Save Logger in static filed in MethodUtils instead of requesting it on every method invocation
Date Mon, 06 May 2013 06:38:16 GMT

    [ https://issues.apache.org/jira/browse/BEANUTILS-439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13649541#comment-13649541
] 

Benedikt Ritter commented on BEANUTILS-439:
-------------------------------------------

{quote}
AIUI, using a static logger may cause problems in some environments.
{quote}

Oh, I didn't know this. I'd like to learn more about this. Do you have docs on this?

{quote}
Maybe the logger could be cached instead?
{quote}

Wouldn't that result in the same problem? We would have to cache it in a static field (to
access it from the static methods). The only alternative I see is to create an instance delegate
like BeanUtilsBean but for MethodUtils.

But in general I agree with what you have stated several times: commons components should
not do logging at all but instead leave this to code higher up in the tier.
                
> Save Logger in static filed in MethodUtils instead of requesting it on every method invocation
> ----------------------------------------------------------------------------------------------
>
>                 Key: BEANUTILS-439
>                 URL: https://issues.apache.org/jira/browse/BEANUTILS-439
>             Project: Commons BeanUtils
>          Issue Type: Improvement
>          Components: Bean / Property Utils
>    Affects Versions: 1.8.3
>            Reporter: Benedikt Ritter
>            Assignee: Benedikt Ritter
>              Labels: logging, performance
>             Fix For: 1.8.4
>
>
> It was proposed on the ML to create a static field reference to the Logger in MethodUtils,
because requesting it on every method invocation leads to bad performance (see http://markmail.org/message/ysurofedfoikdguu).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message