commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (DBUTILS-109) AbstractExecutor.currentPosition should be an int
Date Mon, 13 May 2013 20:49:18 GMT

     [ https://issues.apache.org/jira/browse/DBUTILS-109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Sebb resolved DBUTILS-109.
--------------------------

       Resolution: Fixed
    Fix Version/s: 2.0

Fixed in http://svn.apache.org/r1481212
                
> AbstractExecutor.currentPosition should be an int
> -------------------------------------------------
>
>                 Key: DBUTILS-109
>                 URL: https://issues.apache.org/jira/browse/DBUTILS-109
>             Project: Commons DbUtils
>          Issue Type: Bug
>            Reporter: Sebb
>             Fix For: 2.0
>
>
> AbstractExecutor.currentPosition is currently an Integer.
> It is only used here:
> posList.add(++currentPosition);
> This involves converting the Integer to an int, incrementing the int and then converting
back to an Integer.
> It would be rather more efficient to create the field as an int.
> Alternatively, if the class is supposed to be thread-safe, maybe an AtomicInteger would
be better.
> Integer is not the best choice here.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message