commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (COLLECTIONS-455) AbstractDualBidiMap<K, V> has several mutable protected fields
Date Mon, 29 Apr 2013 00:24:16 GMT

    [ https://issues.apache.org/jira/browse/COLLECTIONS-455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13644180#comment-13644180
] 

Sebb commented on COLLECTIONS-455:
----------------------------------

Likewise for:

AbstractCollectionDecorator
AbstractUntypedCollectionDecorator
CompositeCollection
PredicatedCollection
SynchronizedCollection
TransformedCollection
EditCommand
ComparatorChain
AbstractQuantifierPredicate
ArrayIterator
ArrayListIterator
IteratorChain
NodeListIterator
ObjectArrayIterator
ObjectArrayListIterator
ObjectGraphIterator
AbstractKeyValue
AbstractMapEntryDecorator (the field is final but the object is not immutable)
AbstractLinkedList
CursorableLinkedList
NodeCachingLinkedList
SetUniqueList
AbstractHashedMap
AbstractLinkedMap
AbstractMapDecorator
AbstractReferenceMap

etc.
                
> AbstractDualBidiMap<K, V> has several mutable protected fields
> --------------------------------------------------------------
>
>                 Key: COLLECTIONS-455
>                 URL: https://issues.apache.org/jira/browse/COLLECTIONS-455
>             Project: Commons Collections
>          Issue Type: Bug
>            Reporter: Sebb
>
> Any non-private mutable fields make it much harder to ensure thread-safety as well as
making it very difficult to test thoroughly.
> The fields should be made private.
> If protected write access really is needed, setter methods should be used.
> These methods can take any necessary precautions to ensure thread-safety.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message