commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IO-328) FileUtils.listFilesAndDirs includes original dir in results even when it doesn't match filter
Date Tue, 16 Apr 2013 21:59:16 GMT

    [ https://issues.apache.org/jira/browse/IO-328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13633443#comment-13633443
] 

Sebb commented on IO-328:
-------------------------

I think the Javadoc is correct as it stands, though perhaps a bit ambiguous.

The Javadoc says:

bq. All files found are filtered by an IOFileFilter.

Directories are not mentioned.

bq. The resulting collection includes the subdirectories themselves.

That is ambiguous; it should probably read:

bq. The resulting collection includes the directories themselves.

                
> FileUtils.listFilesAndDirs includes original dir in results even when it doesn't match
filter
> ---------------------------------------------------------------------------------------------
>
>                 Key: IO-328
>                 URL: https://issues.apache.org/jira/browse/IO-328
>             Project: Commons IO
>          Issue Type: Bug
>            Reporter: Hoss Man
>         Attachments: IO-328.patch, IO-328.testcase.patch
>
>
> listFilesAndDirs seems to always include the "directory" passed as input in it's resulting
Collection.  This is unexpected given the docs for the method...
> bq. Finds files within a given directory (and optionally its subdirectories). All files
found are filtered by an IOFileFilter. 
> * the "given directory" is not a subdirectory of itself
> * it is not subjected to the IOFileFilter dirFilter, it is always added.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message