commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Neidhart (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (COLLECTIONS-232) Some tests contain assertEquals arguments in the incorrect order
Date Sat, 27 Apr 2013 21:48:15 GMT

     [ https://issues.apache.org/jira/browse/COLLECTIONS-232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Thomas Neidhart updated COLLECTIONS-232:
----------------------------------------

    Fix Version/s:     (was: 4.0-beta-1)
                   4.0
    
> Some tests contain assertEquals arguments in the incorrect order
> ----------------------------------------------------------------
>
>                 Key: COLLECTIONS-232
>                 URL: https://issues.apache.org/jira/browse/COLLECTIONS-232
>             Project: Commons Collections
>          Issue Type: Improvement
>            Reporter: Mark Hindess
>            Priority: Trivial
>             Fix For: 4.0
>
>         Attachments: fix.assertEquals.usage.diff
>
>
> A few tests have the expected and actual arguments to assertEquals in the wrong order.
 This can lead to very confusing failure messages.  I'll attach a patch to fix some of the
more obvious ones.  I've also replaced a couple of assertTrue(blah.size() == 0) with assertEquals(0,
blah.size()) since the later typically gives a more helpful failure message.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message