commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Neidhart (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (COLLECTIONS-215) Javadoc in DefaultedMap very inconsistent
Date Sat, 27 Apr 2013 21:26:16 GMT

     [ https://issues.apache.org/jira/browse/COLLECTIONS-215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Thomas Neidhart updated COLLECTIONS-215:
----------------------------------------

    Fix Version/s:     (was: 4.0-beta-1)
    
> Javadoc in DefaultedMap very inconsistent
> -----------------------------------------
>
>                 Key: COLLECTIONS-215
>                 URL: https://issues.apache.org/jira/browse/COLLECTIONS-215
>             Project: Commons Collections
>          Issue Type: Improvement
>    Affects Versions: 3.2
>            Reporter: Hendrik Maryns
>            Assignee: Stephen Colebourne
>         Attachments: DefaultedMap.diff
>
>
> The javadocs in DefaultedMap is very inconsistent.  It speaks
> of factory
>  when a transformer is meant, it speaks of transformer when value is
>  meant and that sort of stuff. 
>  
>  Besides, it would be much cleaner to declare 'value' of type
>  Transformer, and create a transformer every time, except when one is
>  passed (the instanceof checks are wrong anyway), (I'd rename it to
>  transformer, too). 
>  
>  Even nicer would be to split up the constructor(s) into one
>  that takes a
>  value, and one that takes a Transformer, no instanceof checks needed,
>  much cleaner code, generification is almost trivial  :-) 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message