Return-Path: X-Original-To: apmail-commons-issues-archive@minotaur.apache.org Delivered-To: apmail-commons-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E4DFFEE7E for ; Sat, 16 Mar 2013 18:36:12 +0000 (UTC) Received: (qmail 90253 invoked by uid 500); 16 Mar 2013 18:36:12 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 90155 invoked by uid 500); 16 Mar 2013 18:36:12 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 90146 invoked by uid 99); 16 Mar 2013 18:36:12 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 16 Mar 2013 18:36:12 +0000 Date: Sat, 16 Mar 2013 18:36:12 +0000 (UTC) From: "Sebb (JIRA)" To: issues@commons.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Resolved] (FILEUPLOAD-229) toLowerCase() is Locale-dependent; should use toLowerCase(Locale.ENGLISH) instead MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/FILEUPLOAD-229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb resolved FILEUPLOAD-229. ----------------------------- Resolution: Fixed URL: http://svn.apache.org/r1457288 Log: FILEUPLOAD-229 - toLowerCase() is Locale-dependent; should use toLowerCase(Locale.ENGLISH) instead Modified: commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/FileUploadBase.java commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/util/FileItemHeadersImpl.java > toLowerCase() is Locale-dependent; should use toLowerCase(Locale.ENGLISH) instead > --------------------------------------------------------------------------------- > > Key: FILEUPLOAD-229 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-229 > Project: Commons FileUpload > Issue Type: Bug > Reporter: Sebb > Fix For: 1.3 > > > toLowerCase() is Locale-dependent - as is toUpperCase(). > For comparisons, can often use equalsIgnoreCase(String) instead. > If an actual lower/upper case is required, then should use a fixed locale (unless the code is intended to use the default locale, which is quite unusual for Commons) > A suitable locale is Locale.ENGLISH as that behaves well with ASCII and ISO-8859-1. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira