Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Date: Thu, 7 Mar 2013 07:12:14 +0000 (UTC)
From: =?utf-8?Q?Jan_Novotn=C3=BD_=28JIRA=29?= <jira@apache.org>
To: issues@commons.apache.org
Message-ID: <JIRA.12503607.1302163495509.397937.1362640334775@arcas>
In-Reply-To: <JIRA.12503607.1302163495509@arcas>
References: <JIRA.12503607.1302163495509@arcas>
Subject: [jira] [Commented] (FILEUPLOAD-189) DiskFileItemFactory use of
 FileCleaningTracker is documated or coded wrong
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/FILEUPLOAD-189?page=3Dcom.atlas=
sian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D=
13595629#comment-13595629 ]=20

Jan Novotn=C3=BD commented on FILEUPLOAD-189:
----------------------------------------

You're welcome. I think I'm not worthy to become a contributor by writing a=
 single line of code :) ... thank you.
               =20
> DiskFileItemFactory use of FileCleaningTracker is documated or coded wron=
g
> -------------------------------------------------------------------------=
-
>
>                 Key: FILEUPLOAD-189
>                 URL: https://issues.apache.org/jira/browse/FILEUPLOAD-189
>             Project: Commons FileUpload
>          Issue Type: Bug
>    Affects Versions: 1.2.2
>            Reporter: Gregor K
>            Assignee: Simone Tripodi
>            Priority: Minor
>             Fix For: 1.3
>
>         Attachments: FILEUPLOAD-189.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Regarding latest SVN revision:
> The DiskFileItemFactory documents:
> Temporary files are automatically deleted as soon as they are no longer n=
eeded. (More precisely, when the corresponding instance of {@link java.io.F=
ile} is garbage collected.)
> But the code in DiskFileItemFactory.createItem() is doing:
> tracker.track(result.getTempFile(), this);
> Which means the file is cleaned when DiskFileItemFactory is garbage colle=
cted.
> This error is propably introduced in Rev 578253 when the code was moved f=
rom DiskFileItem to DiskFileItemFactory, without changing "this" (which was=
 DiskFileItem) and is not DiskFileItemFactory.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrato=
rs
For more information on JIRA, see: http://www.atlassian.com/software/jira