Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Date: Mon, 11 Mar 2013 10:49:14 +0000 (UTC)
From: "Luc Maisonobe (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Message-ID: <JIRA.12495622.1295036431195.417980.1362998954171@arcas>
In-Reply-To: <JIRA.12495622.1295036431195@arcas>
References: <JIRA.12495622.1295036431195@arcas>
Subject: [jira] [Resolved] (MATH-476) FastMath code contains 'magic'
 numbers, e.g. (-)4503599627370496.0
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/MATH-476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Luc Maisonobe resolved MATH-476.
--------------------------------

    Resolution: Fixed

Declaring as resolved as per comments above.
                
> FastMath code contains 'magic' numbers, e.g. (-)4503599627370496.0
> ------------------------------------------------------------------
>
>                 Key: MATH-476
>                 URL: https://issues.apache.org/jira/browse/MATH-476
>             Project: Commons Math
>          Issue Type: Improvement
>    Affects Versions: 2.2
>            Reporter: Sebb
>            Priority: Minor
>             Fix For: 3.2
>
>
> The FastMath class contains quite a few 'magic' numbers, not all of which are explained/documented.
> For example, how is the number (-)4503599627370496.0 calculated?
> IMO, all magic numbers should be replaced by constants with a descriptive name and explanatory Javadoc.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira