commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (FILEUPLOAD-229) toLowerCase() is Locale-dependent; should use toLowerCase(Locale.ENGLISH) instead
Date Sat, 16 Mar 2013 18:36:12 GMT

     [ https://issues.apache.org/jira/browse/FILEUPLOAD-229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Sebb resolved FILEUPLOAD-229.
-----------------------------

    Resolution: Fixed

URL: http://svn.apache.org/r1457288
Log:
FILEUPLOAD-229 - toLowerCase() is Locale-dependent; should use toLowerCase(Locale.ENGLISH)
instead

Modified:
    commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/FileUploadBase.java
    commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/util/FileItemHeadersImpl.java

                
> toLowerCase() is Locale-dependent; should use toLowerCase(Locale.ENGLISH) instead
> ---------------------------------------------------------------------------------
>
>                 Key: FILEUPLOAD-229
>                 URL: https://issues.apache.org/jira/browse/FILEUPLOAD-229
>             Project: Commons FileUpload
>          Issue Type: Bug
>            Reporter: Sebb
>             Fix For: 1.3
>
>
> toLowerCase() is Locale-dependent - as is toUpperCase().
> For comparisons, can often use equalsIgnoreCase(String) instead.
> If an actual lower/upper case is required, then should use a fixed locale (unless the
code is intended to use the default locale, which is quite unusual for Commons)
> A suitable locale is Locale.ENGLISH as that behaves well with ASCII and ISO-8859-1.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message