commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konstantin Kolinko (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DAEMON-284) Service configuration corruption on install
Date Thu, 07 Mar 2013 00:04:14 GMT

    [ https://issues.apache.org/jira/browse/DAEMON-284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13595309#comment-13595309
] 

Konstantin Kolinko commented on DAEMON-284:
-------------------------------------------

In \src\native\windows\apps\prunsrv\prunsrv.c
 method docmdInstallService(..) line 588

Replace
 lstrlcatW(szName, SIZ_BUFLEN, L"//RS//");
 lstrlcatW(szName, SIZ_HUGLEN, lpCmdline->szApplication);
with
 lstrlcpyW(szName, SIZ_BUFLEN, L"//RS//");
 lstrlcatW(szName, SIZ_BUFLEN, lpCmdline->szApplication);

1) wrong method name on the first line, s/cat/cpy/
2) wrong size on the second line, s/HUG/BUF/

Introduced by r1412017


BTW, several lines above, on line 583
 lstrcpyW(szImage, SO_INSTALL);
I wonder why it is not "lstrlcpyW".
                
> Service configuration corruption on install
> -------------------------------------------
>
>                 Key: DAEMON-284
>                 URL: https://issues.apache.org/jira/browse/DAEMON-284
>             Project: Commons Daemon
>          Issue Type: Bug
>    Affects Versions: 1.0.13
>            Reporter: Mark Thomas
>
> Reported to the Tomcat bugzilla [1] and Tomcat users list [2].
> This has only been reported against 7.0.37 which is the first Tomcat version to use 1.0.13.
> [1] https://issues.apache.org/bugzilla/show_bug.cgi?id=54609
> [2] http://tomcat.markmail.org/thread/ojw7xsbzowvwy3jv

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message