commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jeffrey Barnes (JIRA)" <>
Subject [jira] [Updated] (COLLECTIONS-433) TreeList.addAll() complexity
Date Sun, 03 Mar 2013 03:51:13 GMT


Jeffrey Barnes updated COLLECTIONS-433:

    Attachment: COLLECTIONS-433.v2.patch

I have opened a new issue for the {{TreeListIterator}} bug, COLLECTIONS-447, per your suggestion,
which includes a test case and a patch. I am attaching a new patch here that (1) replaces
{{ArrayStack}} with an ordinary Java 5 {{Stack}} and (2) omits the {{TreeListIterator}} fix.
However, this bug should now be considered dependent on COLLECTIONS-447, since this patch
will cause a unit test to fail unless the {{TreeListIterator}} patch is applied first.
> TreeList.addAll() complexity
> ----------------------------
>                 Key: COLLECTIONS-433
>                 URL:
>             Project: Commons Collections
>          Issue Type: Improvement
>    Affects Versions: 3.2.1
>            Reporter: Adrian Nistor
>         Attachments: COLLECTIONS-433.patch, COLLECTIONS-433.v2.patch
> "TreeList.addAll(Collection coll)" has a higher complexity than
> necessary when "coll" is a "TreeList" object (because "addAll" just
> adds one element at a time).  This can be done in just O(N) as
> described for example here:
> Are there any plans to improve this?

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

View raw message