commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Novotný (JIRA) <>
Subject [jira] [Commented] (FILEUPLOAD-189) DiskFileItemFactory use of FileCleaningTracker is documated or coded wrong
Date Thu, 07 Mar 2013 07:12:14 GMT


Jan Novotný commented on FILEUPLOAD-189:

You're welcome. I think I'm not worthy to become a contributor by writing a single line of
code :) ... thank you.
> DiskFileItemFactory use of FileCleaningTracker is documated or coded wrong
> --------------------------------------------------------------------------
>                 Key: FILEUPLOAD-189
>                 URL:
>             Project: Commons FileUpload
>          Issue Type: Bug
>    Affects Versions: 1.2.2
>            Reporter: Gregor K
>            Assignee: Simone Tripodi
>            Priority: Minor
>             Fix For: 1.3
>         Attachments: FILEUPLOAD-189.patch
>   Original Estimate: 1h
>  Remaining Estimate: 1h
> Regarding latest SVN revision:
> The DiskFileItemFactory documents:
> Temporary files are automatically deleted as soon as they are no longer needed. (More
precisely, when the corresponding instance of {@link} is garbage collected.)
> But the code in DiskFileItemFactory.createItem() is doing:
> tracker.track(result.getTempFile(), this);
> Which means the file is cleaned when DiskFileItemFactory is garbage collected.
> This error is propably introduced in Rev 578253 when the code was moved from DiskFileItem
to DiskFileItemFactory, without changing "this" (which was DiskFileItem) and is not DiskFileItemFactory.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

View raw message