commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Neidhart (JIRA)" <>
Subject [jira] [Commented] (COLLECTIONS-325) Improve thread-safety of ExtendedProperties
Date Wed, 13 Mar 2013 20:00:14 GMT


Thomas Neidhart commented on COLLECTIONS-325:

The class javadoc already states that it would probably a better idea to use commons-configuration.
So I wonder if we should not take the opportunity (release 4.0) and remove the class completely.

Any objections?
> Improve thread-safety of ExtendedProperties
> -------------------------------------------
>                 Key: COLLECTIONS-325
>                 URL:
>             Project: Commons Collections
>          Issue Type: Improvement
>            Reporter: Sebb
> It looks as though ExtendedProperties is intended to be thread-safe, otherwise why bother
synchronizing load() and save()?
> If so, then ExtendedProperties field "isInitialized" should be made volatile to ensure
the variable is correctly published.
> Likewise, the field "includePropertyName" needs to be volatile or synchronised.
> Also, the following protected variables could be made final to improve thread-safety:
> defaults
> file
> basePath
> fileSeparator - this could perhaps be static too?
> keysAsListed
> Regardless of thread-safety issues, does it make sense for these variables to be changed
once initialised?

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

View raw message