commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Neidhart (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FILEUPLOAD-137) MultipartStream public API broken
Date Sun, 10 Mar 2013 12:07:12 GMT

    [ https://issues.apache.org/jira/browse/FILEUPLOAD-137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13598218#comment-13598218
] 

Thomas Neidhart commented on FILEUPLOAD-137:
--------------------------------------------

The calls to the notifier are now protected by a null check, so this should be safe.

The default constructor MultipartStream() will still cause a NullPointerException.
I would suggest to throw something like a IllegalStateException in any case and document it
in the javadoc.
It is deprecated anyway and will be removed.
                
> MultipartStream public API broken
> ---------------------------------
>
>                 Key: FILEUPLOAD-137
>                 URL: https://issues.apache.org/jira/browse/FILEUPLOAD-137
>             Project: Commons FileUpload
>          Issue Type: Bug
>    Affects Versions: 1.2
>            Reporter: Mark Sinke
>            Assignee: Jochen Wiedmann
>             Fix For: 1.2.1
>
>
> In commons-transaction 1.2 the MultipartStream class has 2 public constructors. Both
are deprecated; however their implementation delegates to non-visible (package-private) constructors.
There are two issues here:
> 1. the deprecated, delegating constructors use a null pointer for the progress notifier,
which in turn yield a NullPointerException when you try to use them
> 2. the non-deprecated constructors are not visible.
> Hence, I cannot really upgrade from 1.0 to 1.2.
> Thanks,
> Mark.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message