Return-Path: X-Original-To: apmail-commons-issues-archive@minotaur.apache.org Delivered-To: apmail-commons-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A896CE21D for ; Sun, 3 Feb 2013 15:08:15 +0000 (UTC) Received: (qmail 63297 invoked by uid 500); 3 Feb 2013 15:08:15 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 63026 invoked by uid 500); 3 Feb 2013 15:08:14 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 62975 invoked by uid 99); 3 Feb 2013 15:08:13 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 03 Feb 2013 15:08:13 +0000 Date: Sun, 3 Feb 2013 15:08:13 +0000 (UTC) From: "Sebb (JIRA)" To: issues@commons.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (NET-500) FTPClientExample does binary transfers by default instead of ASCII as stated in documentation MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/NET-500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13569793#comment-13569793 ] Sebb commented on NET-500: -------------------------- URL: http://svn.apache.org/viewvc?rev=1441925&view=rev Log: NET-500 Always call FTPClient#setFileType after connection Modified: commons/proper/net/trunk/src/changes/changes.xml commons/proper/net/trunk/src/main/java/org/apache/commons/net/ftp/FTPClient.java URL: http://svn.apache.org/viewvc?rev=1441921&view=rev Log: NET-500 - servers don't default to ASCII Modified: commons/proper/net/trunk/src/main/java/examples/ftp/FTPClientExample.java > FTPClientExample does binary transfers by default instead of ASCII as stated in documentation > --------------------------------------------------------------------------------------------- > > Key: NET-500 > URL: https://issues.apache.org/jira/browse/NET-500 > Project: Commons Net > Issue Type: Improvement > Components: FTP > Affects Versions: 3.2 > Environment: all environments concerned > Reporter: Michael Frick > Priority: Trivial > Labels: patch > Fix For: 3.2 > > > Following change should be added to the FTPClientExample class, otherwise > the default ASCII setting will not be set. > if (binaryTransfer) { > ftp.setFileType(FTP.BINARY_FILE_TYPE); > } > // Added else to set correct default file type / M. Frick 2013-02-03 > // Default ftp class file type seems to be binary! > else > { > ftp.setFileType(FTP.ASCII_FILE_TYPE); > } > // End of change / M. Frick 2013-02-03 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira