Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Date: Thu, 28 Feb 2013 19:59:16 +0000 (UTC)
From: "Thomas Neidhart (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Message-ID: <JIRA.12414889.1234812488733.360259.1362081556413@arcas>
In-Reply-To: <JIRA.12414889.1234812488733@arcas>
References: <JIRA.12414889.1234812488733@arcas>
Subject: [jira] [Resolved] (COLLECTIONS-318) CollectionUtils.size(Object
 object) has impossible null check
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/COLLECTIONS-318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thomas Neidhart resolved COLLECTIONS-318.
-----------------------------------------

    Resolution: Fixed
    
> CollectionUtils.size(Object object) has impossible null check
> -------------------------------------------------------------
>
>                 Key: COLLECTIONS-318
>                 URL: https://issues.apache.org/jira/browse/COLLECTIONS-318
>             Project: Commons Collections
>          Issue Type: Bug
>          Components: Collection
>            Reporter: Sebb
>            Priority: Minor
>             Fix For: 4.0
>
>
> CollectionUtils.size(Object object) has impossible null check:
> {code}
>     public static int size(Object object) {
>         if (object == null) {
>             return 0;
>         }
> ...
>         } else if (object == null) {
>             throw new IllegalArgumentException("Unsupported object type: null");
> ...
> {code}
> The Javadoc specifically says that null is allowed, so I think the object == null clause needs to be removed - it can never be true, and is just confusing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira