commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oliver Heger (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CONFIGURATION-527) clearPropertyDirect() in AbstractConfiguration should be abstract
Date Tue, 26 Feb 2013 20:42:13 GMT

    [ https://issues.apache.org/jira/browse/CONFIGURATION-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13587517#comment-13587517
] 

Oliver Heger commented on CONFIGURATION-527:
--------------------------------------------

IIRC, backwards compatibility as mentioned by Jörg was the reason why it was implemented
that way. We are currently working on version 2.0 which will break binary compatibility, so
the patch can be applied.
                
> clearPropertyDirect() in AbstractConfiguration should be abstract
> -----------------------------------------------------------------
>
>                 Key: CONFIGURATION-527
>                 URL: https://issues.apache.org/jira/browse/CONFIGURATION-527
>             Project: Commons Configuration
>          Issue Type: Improvement
>          Components: Build
>    Affects Versions: 1.9
>            Reporter: Matthias Richter
>            Priority: Minor
>         Attachments: patch.diff
>
>
> The method clearPropertyDirect() in AbstractConfiguration has an empty implementation
body. It is documented as "should be overwritten" but is not marked abstract.
> It should be abstract to prevent errors when subclassing AbstractConfiguration and using
the clear() method where (indirectly) clearPropertyDirect() is being called.
> See addPropertyDirect() for comparison, which is abstract.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message