commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthias Richter (JIRA)" <>
Subject [jira] [Commented] (CONFIGURATION-527) clearPropertyDirect() in AbstractConfiguration should be abstract
Date Tue, 26 Feb 2013 13:10:12 GMT


Matthias Richter commented on CONFIGURATION-527:

Yes indeed. Still questionable to have the difference in addPropertyDirect() and clearPropertyDirect().

Now one needs to decide between binary compatibility and abstraction cohesion, I guess. I
would tend to vote for the latter, but it's up to you guys... 
> clearPropertyDirect() in AbstractConfiguration should be abstract
> -----------------------------------------------------------------
>                 Key: CONFIGURATION-527
>                 URL:
>             Project: Commons Configuration
>          Issue Type: Improvement
>          Components: Build
>    Affects Versions: 1.9
>            Reporter: Matthias Richter
>            Priority: Minor
>         Attachments: patch.diff
> The method clearPropertyDirect() in AbstractConfiguration has an empty implementation
body. It is documented as "should be overwritten" but is not marked abstract.
> It should be abstract to prevent errors when subclassing AbstractConfiguration and using
the clear() method where (indirectly) clearPropertyDirect() is being called.
> See addPropertyDirect() for comparison, which is abstract.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

View raw message