commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jean-Marc Borer (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (VFS-467) WebDAV: list children returns parent directory instead of ignoring it
Date Tue, 26 Feb 2013 13:56:12 GMT

    [ https://issues.apache.org/jira/browse/VFS-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13587105#comment-13587105
] 

Jean-Marc Borer edited comment on VFS-467 at 2/26/13 1:55 PM:
--------------------------------------------------------------

Not sure about my fix, but I suppose WebDAV returns always relatives paths. So test should
be:

private boolean isCurrentFile(String href, URLFileName fileName)
    {
        String name = fileName.getPath();
        if (href.endsWith("/") && !name.endsWith("/"))
        {
            name += "/";
        }
        return href.equals(name);
    }
                
      was (Author: jmborer):
    Not sure about my fix, but I suppose WebDAV returns always relatives paths. So test should
be:
                        if (name.getPath().equals(response.getHref()))
                        {
                            continue;
                        }

                  
> WebDAV: list children returns parent directory instead of ignoring it
> ---------------------------------------------------------------------
>
>                 Key: VFS-467
>                 URL: https://issues.apache.org/jira/browse/VFS-467
>             Project: Commons VFS
>          Issue Type: Bug
>    Affects Versions: 2.0, 2.1
>            Reporter: Jean-Marc Borer
>
> WebDAV seems to always include the parent folder when returning a list
> of children for a directory. This is due to a wrong test in WebdavFileObject doListChildrenResolved:
> if (isCurrentFile(response.getHref(), name))
> {
>      continue;
> }
> where the parent dir returned in the WedbDAV response should be ignored. However the
test compares a RELATIVE href (first arg), with an ASBOLUTE href (second arg)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message