commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stefan Schueffler (JIRA)" <>
Subject [jira] [Commented] (EMAIL-124) Header values are folded twice and thus creating defective emails
Date Tue, 26 Feb 2013 17:52:12 GMT


Stefan Schueffler commented on EMAIL-124:


due to my vacational out of office, i unfortunately can not test your commit. But as far as
i can tell from reading your commit mentioned above, your fix looks exactly the same what
i did while analyzing this issue.


> Header values are folded twice and thus creating defective emails
> -----------------------------------------------------------------
>                 Key: EMAIL-124
>                 URL:
>             Project: Commons Email
>          Issue Type: Bug
>    Affects Versions: 1.3
>            Reporter: Stefan Schueffler
>            Priority: Blocker
>             Fix For: 1.3.1
>   Original Estimate: 5m
>  Remaining Estimate: 5m
> With EMAIL-98, header values now are folded by commons-email.
> Unfortunately, they are folded twice: once in "Mail.addHeader" or "Mail.setHeaders",
and once again in "Mail.buildMimeMessage()" while iterating over the headers.
> This results (in our test cases) in corrupted mail header lines having additional blank
lines between the first and second line of a folded value - and thus ends in corrupted mails
(as all headers after the first blank line are threatened as mail-body-content).
> As this renders "additional headers" useless in commons-mail and corrupts every mail
having additionl headers with longer-than-folding-size values, i set the priority to blocker.
> The fix seems to be easy: just fold either in addHeader and setHeaders, or in buildMimeMessage
(but not in both).
> My preferred solution would be to fold in buildMimeMessage, and to store the values "as-is"
in addHeader and setHeaders so one is able to work with the plain values (if neccessary) until
the mail is actually build and send.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

View raw message