commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (NET-500) FTPClientExample does binary transfers by default instead of ASCII as stated in documentation
Date Sun, 03 Feb 2013 15:08:13 GMT

    [ https://issues.apache.org/jira/browse/NET-500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13569793#comment-13569793
] 

Sebb commented on NET-500:
--------------------------

URL: http://svn.apache.org/viewvc?rev=1441925&view=rev
Log:
NET-500 Always call FTPClient#setFileType after connection

Modified:
    commons/proper/net/trunk/src/changes/changes.xml
    commons/proper/net/trunk/src/main/java/org/apache/commons/net/ftp/FTPClient.java

URL: http://svn.apache.org/viewvc?rev=1441921&view=rev
Log:
NET-500 - servers don't default to ASCII

Modified:
    commons/proper/net/trunk/src/main/java/examples/ftp/FTPClientExample.java

                
> FTPClientExample does binary transfers by default instead of ASCII as stated in documentation
> ---------------------------------------------------------------------------------------------
>
>                 Key: NET-500
>                 URL: https://issues.apache.org/jira/browse/NET-500
>             Project: Commons Net
>          Issue Type: Improvement
>          Components: FTP
>    Affects Versions: 3.2
>         Environment: all environments concerned
>            Reporter: Michael Frick
>            Priority: Trivial
>              Labels: patch
>             Fix For: 3.2
>
>
> Following change should be added to the FTPClientExample class, otherwise 
> the default ASCII setting will not be set.
>   if (binaryTransfer) {
>                 ftp.setFileType(FTP.BINARY_FILE_TYPE);
>             }
>             // Added else to set correct default file type / M. Frick 2013-02-03
>             // Default ftp class file type seems to be binary!
>             else
>             {
>                 ftp.setFileType(FTP.ASCII_FILE_TYPE);
>             }
>             // End of change / M. Frick 2013-02-03

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message