commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (LOGGING-144) LogFactory/LogFactoryImpl ingore Throwable
Date Thu, 21 Feb 2013 20:02:12 GMT

    [ https://issues.apache.org/jira/browse/LOGGING-144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13583496#comment-13583496
] 

Sebb edited comment on LOGGING-144 at 2/21/13 8:00 PM:
-------------------------------------------------------

bq. this will also throw additional unchecked exceptions (ThreadDeath & VirtualMachineError)
that where swallowed and logged before?

Well, yes, but those exceptions should never have been swallowed.
                
      was (Author: sebb@apache.org):
    bq. this will also throw additional unchecked exceptions (ThreadDeath & VirtualMachineError)
that where swallowed and logged before?

Well, yes, but those exceptions should never+ have been swallowed.
                  
> LogFactory/LogFactoryImpl ingore Throwable
> ------------------------------------------
>
>                 Key: LOGGING-144
>                 URL: https://issues.apache.org/jira/browse/LOGGING-144
>             Project: Commons Logging
>          Issue Type: Bug
>    Affects Versions: 1.1.1
>            Reporter: Sebb
>         Attachments: LOGGING-144.patch
>
>
> The code in LogFactory/LogFactoryImpl catches and ignores Throwable in several places.
> This is a bad idea, as some Throwables (e.g. ThreadDeath) should never be ignored.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message