commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LOGGING-144) LogFactory/LogFactoryImpl ingore Throwable
Date Thu, 21 Feb 2013 18:18:14 GMT

    [ https://issues.apache.org/jira/browse/LOGGING-144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13583399#comment-13583399
] 

Sebb commented on LOGGING-144:
------------------------------

The patch changes the code to how it should have been written originally.

However, it means that the code may potentially throw some additional unchecked exceptions,
whereas previously the code would log them and continue.

If that is not acceptable, then the alternative approach is to use a method such as

org.apache.tomcat.util.ExceptionUtils.handleThrowable(Throwable t) [1]

For example:

{code}
} catch (Throwable t) {
    handleThrowable(t); // may not return
    logDiagnostic(...);
}
{code}

[1] http://svn.apache.org/repos/asf/tomcat/trunk/java/org/apache/tomcat/util/ExceptionUtils.java
                
> LogFactory/LogFactoryImpl ingore Throwable
> ------------------------------------------
>
>                 Key: LOGGING-144
>                 URL: https://issues.apache.org/jira/browse/LOGGING-144
>             Project: Commons Logging
>          Issue Type: Bug
>    Affects Versions: 1.1.1
>            Reporter: Sebb
>         Attachments: LOGGING-144.patch
>
>
> The code in LogFactory/LogFactoryImpl catches and ignores Throwable in several places.
> This is a bad idea, as some Throwables (e.g. ThreadDeath) should never be ignored.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message