commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Duncan Jones (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLI-224) OptionBuilder only has static methods, yet many return an OptionBuilder instance
Date Sat, 16 Feb 2013 20:03:13 GMT

    [ https://issues.apache.org/jira/browse/CLI-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13580012#comment-13580012
] 

Duncan Jones commented on CLI-224:
----------------------------------

{quote}
What about a static factory method, as always typing new may be tedious?

{code}
  Option.builder().longOpt("v")......build();
{code}
{quote}

Yes, that's a good idea. Do you propose to make the Builder constructors private or are you
leaving those as an alternative?
                
> OptionBuilder only has static methods, yet many return an OptionBuilder instance
> --------------------------------------------------------------------------------
>
>                 Key: CLI-224
>                 URL: https://issues.apache.org/jira/browse/CLI-224
>             Project: Commons CLI
>          Issue Type: Bug
>          Components: CLI-1.x
>    Affects Versions: 1.2
>            Reporter: Brian Blount
>             Fix For: 1.3
>
>         Attachments: commons-cli-CLI-224.patch, DefaultOptionBuilder.java, DefaultOptionBuilderTest.java
>
>
> CLI-83 was closed as fixed in 2.0, but it seems that there is no current plan to release
CLI 2.0.  Could this fix be rolled into the 1.x line?  I'm attaching a new version of option
builder that addresses the issue (named DefaultOptionBuilder to maintain backwards compatability)
and a unit test for it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message