commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gary Gregory (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (VFS-369) Compilation error with newer versions of Jackrabbit
Date Wed, 06 Feb 2013 14:55:13 GMT

    [ https://issues.apache.org/jira/browse/VFS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13566566#comment-13566566
] 

Gary Gregory edited comment on VFS-369 at 2/6/13 2:53 PM:
----------------------------------------------------------

A patch that updates VFS trunk to Jackrabbit 2.5.3 but causes tests to fail:

{noformat}
Running org.apache.commons.vfs2.provider.webdav.test.WebdavProviderTestCase
Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 17.631 sec <<< FAILURE!
junit.framework.TestSuite@5e1c0e6e(org.apache.commons.vfs2.provider.webdav.test.WebdavProviderTestCase$1)
 Time elapsed: 17631 sec  <<< FAILURE!
junit.framework.AssertionFailedError: Folder does not exist: webdav://admin@localhost:55406/repository/default/read-tests
        at junit.framework.Assert.fail(Assert.java:57)
        at junit.framework.Assert.assertTrue(Assert.java:22)
        at org.apache.commons.vfs2.test.AbstractTestSuite.setUp(AbstractTestSuite.java:171)
        at org.apache.commons.vfs2.provider.webdav.test.WebdavProviderTestCase$1.setUp(WebdavProviderTestCase.java:279)
        at junit.extensions.TestSetup$1.protect(TestSetup.java:22)
        at junit.framework.TestResult.runProtected(TestResult.java:142)
        at junit.extensions.TestSetup.run(TestSetup.java:27)
        at org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:84)
        at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:252)
        at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:141)
        at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:112)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
        at java.lang.reflect.Method.invoke(Method.java:597)
        at org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(ReflectionUtils.java:189)
        at org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:165)
        at org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(ProviderFactory.java:85)
        at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:115)
        at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:75)
{noformat}

My set up:

{noformat}
Apache Maven 3.0.4 (r1232337; 2012-01-17 03:44:56-0500)
Maven home: C:\Java\apache-maven-3.0.4\bin\..
Java version: 1.6.0_38, vendor: Sun Microsystems Inc.
Java home: C:\Program Files\Java\jdk1.6.0_38\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"
{noformat}
                
      was (Author: garydgregory):
    A patch that updates VFS trunk to Jackrabbit 2.5.3 but causes tests to fail:

{noformat}
Running org.apache.commons.vfs2.provider.webdav.test.WebdavProviderTestCase
Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 17.631 sec <<< FAILURE!
junit.framework.TestSuite@5e1c0e6e(org.apache.commons.vfs2.provider.webdav.test.WebdavProviderTestCase$1)
 Time elapsed: 17631 sec  <<< FAILURE!
junit.framework.AssertionFailedError: Folder does not exist: webdav://admin@localhost:55406/repository/default/read-tests
        at junit.framework.Assert.fail(Assert.java:57)
        at junit.framework.Assert.assertTrue(Assert.java:22)
        at org.apache.commons.vfs2.test.AbstractTestSuite.setUp(AbstractTestSuite.java:171)
        at org.apache.commons.vfs2.provider.webdav.test.WebdavProviderTestCase$1.setUp(WebdavProviderTestCase.java:279)
        at junit.extensions.TestSetup$1.protect(TestSetup.java:22)
        at junit.framework.TestResult.runProtected(TestResult.java:142)
        at junit.extensions.TestSetup.run(TestSetup.java:27)
        at org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:84)
        at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:252)
        at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:141)
        at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:112)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
        at java.lang.reflect.Method.invoke(Method.java:597)
        at org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(ReflectionUtils.java:189)
        at org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:165)
        at org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(ProviderFactory.java:85)
        at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:115)
        at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:75)
{noformat}

                  
> Compilation error with newer versions of Jackrabbit
> ---------------------------------------------------
>
>                 Key: VFS-369
>                 URL: https://issues.apache.org/jira/browse/VFS-369
>             Project: Commons VFS
>          Issue Type: Bug
>    Affects Versions: 2.0
>            Reporter: Cedric Nanni
>         Attachments: vfs-369-JR-2.5.3.diff, VFS-369.patch
>
>
> When I try to compile VFS on my computer I've got compilation errors due maybe because
I use a more recent version of jackrabbit. I patched the code and now it compiles.
> diff -rupN original//org/apache/commons/vfs2/provider/webdav/ExceptionConverter.java
patched//org/apache/commons/vfs2/provider/webdav/ExceptionConverter.java
> --- original//org/apache/commons/vfs2/provider/webdav/ExceptionConverter.java	2011-08-18
06:57:10.000000000 +0200
> +++ patched//org/apache/commons/vfs2/provider/webdav/ExceptionConverter.java	2011-10-24
20:35:41.000000000 +0200
> @@ -50,7 +50,7 @@ public final class ExceptionConverter
>          {
>              try
>              {
> -                Element error = davExc.toXml(DomUtil.BUILDER_FACTORY.newDocumentBuilder().newDocument());
> +                Element error = davExc.toXml(DomUtil.createDocument());
>                  if (DomUtil.matches(error, DavException.XML_ERROR, DavConstants.NAMESPACE))
>                  {
>                      if (DomUtil.hasChildElement(error, "exception", null))
> diff -rupN original//org/apache/commons/vfs2/provider/webdav/WebdavFileObject.java patched//org/apache/commons/vfs2/provider/webdav/WebdavFileObject.java
> --- original//org/apache/commons/vfs2/provider/webdav/WebdavFileObject.java	2011-08-18
06:57:10.000000000 +0200
> +++ patched//org/apache/commons/vfs2/provider/webdav/WebdavFileObject.java	2011-10-24
20:35:41.000000000 +0200
> @@ -292,19 +292,17 @@ public class WebdavFileObject extends Ht
>              URLFileName fileName = (URLFileName) getName();
>              DavPropertySet properties = getProperties(fileName, PropFindMethod.PROPFIND_ALL_PROP,
>                      new DavPropertyNameSet(), false);
> -            @SuppressWarnings("unchecked") // iterator() is documented to return DavProperty
instances
> -            Iterator<DavProperty> iter = properties.iterator();
> +            Iterator iter = properties.iterator();
>              while (iter.hasNext())
>              {
> -                DavProperty property = iter.next();
> +                DavProperty property = (DavProperty)iter.next();
>                  attributes.put(property.getName().toString(), property.getValue());
>              }
>              properties = getPropertyNames(fileName);
> -            @SuppressWarnings("unchecked") // iterator() is documented to return DavProperty
instances
> -            Iterator<DavProperty> iter2 = properties.iterator();
> +            Iterator iter2 = properties.iterator();
>              while (iter2.hasNext())
>              {
> -                DavProperty property = iter2.next();
> +                DavProperty property = (DavProperty)iter2.next();
>                  if (!attributes.containsKey(property.getName().getName()))
>                  {
>                      property = getProperty(fileName, property.getName());

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message