Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Date: Wed, 30 Jan 2013 04:43:13 +0000 (UTC)
From: "Gary Gregory (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Message-ID: <JIRA.12613453.1351155207135.213418.1359520993816@arcas>
In-Reply-To: <JIRA.12613453.1351155207135@arcas>
References: <JIRA.12613453.1351155207135@arcas>
Subject: [jira] [Commented] (CODEC-161) Add Match Rating Approach (MRA)
 phonetic algorithm encoder
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CODEC-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13566156#comment-13566156 ] 

Gary Gregory commented on CODEC-161:
------------------------------------

Hello, sorry about the delay.

I just looked at the Jab 24 patch https://issues.apache.org/jira/secure/attachment/12566307/CODEC-161-24Jan2013.patch

I am not a fan of changing all of the if/else's to if's because in the worst case all if's must be evaluated.

I'm going resolve this issue and let other committers make any changes if they feel like it.
                
> Add Match Rating Approach (MRA) phonetic algorithm encoder
> ----------------------------------------------------------
>
>                 Key: CODEC-161
>                 URL: https://issues.apache.org/jira/browse/CODEC-161
>             Project: Commons Codec
>          Issue Type: New Feature
>    Affects Versions: 1.6
>            Reporter: Colm Rice
>            Priority: Minor
>              Labels: newbie
>             Fix For: 1.8
>
>         Attachments: CODEC-161-18Jan2013.patch, CODEC-161-23Jan2013.patch, CODEC-161-24Jan2013.patch, CODEC-161-MatchRatingApproach.patch, CODEC-161.patch, CODEC-161.patch, CODEC-161.patch, CODEC-161.patch, CODEC-161.patch, Code_Coverage_EclEmma_MRA_TargetAlgo_03Dec2012.jpg, CODED-161.patch, MRA_Cobertura_CodeCoverage_18Jan2013.jpg, MRA_Cobertura_Code_Coverage_DeMorganElseIfWorkaround.jpg, MRA_Cobertura_ScreenShot_01Jan2013.jpg, MRA_eCobertura_Output.jpg
>
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> I want to add MatchRatingApproach algorithm to the Lucene project via commons codec.
> What I have at the moment is a class called org.apache.lucene.analysis.phoenetic.MatchRatingApproach implementing StringEncoder
> I have a pretty comprehensive test file located at: org.apache.lucene.analysis.phonetic.MatchRatingApproachTests
> It's not exactly existing pattern so I'm going to need a bit of advice here. Thanks! Feel free to email.
> FYI: It my first contribution so be gentle :-)  C# is my native.
> I had incorrectly added this to Lucene solution as LUCENE-4494 but received some good advice to move it to here. I'm doing that now.
> Reference: http://en.wikipedia.org/wiki/Match_rating_approach

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira