commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Colm Rice (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CODEC-161) Add Match Rating Approach (MRA) phonetic algorithm encoder
Date Wed, 23 Jan 2013 12:04:12 GMT

    [ https://issues.apache.org/jira/browse/CODEC-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13560601#comment-13560601
] 

Colm Rice commented on CODEC-161:
---------------------------------

Hi Gary, yes. I was trying earnestly to boost the Cobertura branch coverage metric from 97%
to 100%. I noticed that when I coded stuff like:

else if ((sumLength >= 5) && (sumLength <= 7))

Cobertura would say something like "only 75% (3/4) of the branch was covered" or a comment
to that effect Gary. I'm don't know why. I increased specific tests and did the clean/test/build
routine again but, alas, got the same message. Am I missing something in my dodgy new found
Java skills or is this a little quirk with such a conditional statement involving the "&&"
inside Cobertura? I'm using Cobertura v1.9.4.1

Should I reset and live with 97% perhaps?
                
> Add Match Rating Approach (MRA) phonetic algorithm encoder
> ----------------------------------------------------------
>
>                 Key: CODEC-161
>                 URL: https://issues.apache.org/jira/browse/CODEC-161
>             Project: Commons Codec
>          Issue Type: New Feature
>    Affects Versions: 1.6
>            Reporter: Colm Rice
>            Priority: Minor
>              Labels: newbie
>             Fix For: 1.8
>
>         Attachments: CODEC-161-18Jan2013.patch, CODEC-161-MatchRatingApproach.patch,
CODEC-161.patch, CODEC-161.patch, CODEC-161.patch, CODEC-161.patch, CODEC-161.patch, Code_Coverage_EclEmma_MRA_TargetAlgo_03Dec2012.jpg,
CODED-161.patch, MRA_Cobertura_CodeCoverage_18Jan2013.jpg, MRA_Cobertura_ScreenShot_01Jan2013.jpg,
MRA_eCobertura_Output.jpg
>
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> I want to add MatchRatingApproach algorithm to the Lucene project via commons codec.
> What I have at the moment is a class called org.apache.lucene.analysis.phoenetic.MatchRatingApproach
implementing StringEncoder
> I have a pretty comprehensive test file located at: org.apache.lucene.analysis.phonetic.MatchRatingApproachTests
> It's not exactly existing pattern so I'm going to need a bit of advice here. Thanks!
Feel free to email.
> FYI: It my first contribution so be gentle :-)  C# is my native.
> I had incorrectly added this to Lucene solution as LUCENE-4494 but received some good
advice to move it to here. I'm doing that now.
> Reference: http://en.wikipedia.org/wiki/Match_rating_approach

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message