commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (NET-310) FTPCommand conversion to use enum
Date Wed, 23 Jan 2013 17:45:18 GMT

    [ https://issues.apache.org/jira/browse/NET-310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13560862#comment-13560862
] 

Sebb commented on NET-310:
--------------------------

Note: it would be possible to record the original constants with the enum, for example:

{noformat}
    ABOR(FTPCommand.ABOR),
...
    USER(FTPCommand.USER),

    private final int originalCode;
    
    FTPCommandEnum(int original) {
        originalCode=original;
    }
    
    int getOriginalCode() {
        return originalCode;
    }
{noformat}

However, there does not seem to be any need for this.
                
> FTPCommand conversion to use enum
> ---------------------------------
>
>                 Key: NET-310
>                 URL: https://issues.apache.org/jira/browse/NET-310
>             Project: Commons Net
>          Issue Type: Improvement
>          Components: FTP
>            Reporter: Sebb
>            Priority: Minor
>         Attachments: FTPCmd.patch, FTPCommandEnum.patch
>
>
> Seems to me it would be sensible to replace the integer values in the FTPCommand class
with an enum.
> I propose creating a new enum class (called FTPCommands) which contains the enum and
aliases. The existing FTPCommand class is then rewritten using the enum ordinals; and the
FTP class is changed to use the enums internally. Existing public methods which use an integer
for the command id are deprecated.
> If there are any further commands added to the set lter, they should only be added to
the enum, and no corresponding ints should be defined.
> See attached patch (to follow). I've not fixed the FTP subclasses yet as I wanted to
get agreement on the approach first.
> Note that the new class name FTPCommands is very similar to the old class FTPCommand;
of course that can be changed.
> Comments? Suggestions?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message