commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Neidhart (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (COLLECTIONS-322) Adds a Collections wrapper around the w3c NodeList
Date Wed, 23 Jan 2013 16:50:14 GMT

    [ https://issues.apache.org/jira/browse/COLLECTIONS-322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13560818#comment-13560818
] 

Thomas Neidhart commented on COLLECTIONS-322:
---------------------------------------------

Hi Thomas,

I looked at your patch and it looks pretty good, thanks for that.
As you pointed out yourself, maybe a better solution would be to provide static helper methods
to more easily iterate on a w3c DOM list.

Feel free to provide a patch for that too.

Thanks,

Thomas
                
> Adds a Collections wrapper around the w3c NodeList
> --------------------------------------------------
>
>                 Key: COLLECTIONS-322
>                 URL: https://issues.apache.org/jira/browse/COLLECTIONS-322
>             Project: Commons Collections
>          Issue Type: Improvement
>          Components: List
>            Reporter: Hasan Diwan
>            Priority: Minor
>             Fix For: 4.0
>
>         Attachments: NodeListAsCollection.java, patch.txt, TestNodeListAsCollection.java
>
>
> org.w3c.dom.NodeList is defined as an "abstract collection of Nodes" and java.util.List
is defined as "An ordered collection (also known as a sequence). The user of this interface
has precise control over where in the list each element is inserted. The user can access elements
by their integer index (position in the list), and search for elements in the list.". It seemed
similar enough, so I did an implementation of the useful methods, while throwing the appropriate
exception when the method wouldn't make sense.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message