Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Date: Mon, 31 Dec 2012 11:48:12 +0000 (UTC)
From: "Stefan Bodewig (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Message-ID: <JIRA.12609792.1349117622889.65661.1356954492663@arcas>
In-Reply-To: <JIRA.12609792.1349117622889@arcas>
References: <JIRA.12609792.1349117622889@arcas>
Subject: [jira] [Commented] (COMPRESS-205) Unit tests can fail when path to
 project is non-trivial (fix in description)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/COMPRESS-205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13541348#comment-13541348 ] 

Stefan Bodewig commented on COMPRESS-205:
-----------------------------------------

Some of our tests will need real File instances (at least those of ZipFile and some Pack200 ones), but we could make thse tests conditional or use JUnit4 assumptions.  I'll look into it a bit later.
                
> Unit tests can fail when path to project is non-trivial (fix in description)
> ----------------------------------------------------------------------------
>
>                 Key: COMPRESS-205
>                 URL: https://issues.apache.org/jira/browse/COMPRESS-205
>             Project: Commons Compress
>          Issue Type: Bug
>    Affects Versions: 1.5
>            Reporter: Daniel Lowe
>            Priority: Minor
>         Attachments: COMPRESS-205.patch
>
>
> return factory.createCompressorInputStream(new BufferedInputStream(new FileInputStream(new File(rsc.getFile()))));
> can fail to find the files for testing e.g. /root/.jenkins/jobs/Commons%20Compress/workspace/target/test-classes/test.txt (No such file or directory)
> This can be fixed by simply opening the stream from the URL:
>     private CompressorInputStream getStreamFor(String resource)
>             throws CompressorException, IOException {
>         final URL rsc = classLoader.getResource(resource);
>         assertNotNull("Could not find resource "+resource,rsc);
>         return factory.createCompressorInputStream(
>                    new BufferedInputStream(rsc.openStream()));
>     }

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira