commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Colm Rice (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CODEC-161) Add Match Rating Approach (MRA) phonetic algorithm encoder
Date Wed, 12 Dec 2012 12:13:33 GMT

    [ https://issues.apache.org/jira/browse/CODEC-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13529878#comment-13529878
] 

Colm Rice commented on CODEC-161:
---------------------------------

Hi Gary,

   Thanks for your version, some nice changes all right. I'm coming in from C# so much appreciated.
I have increased test-code coverage and according to EclEmma add-on screen-shot (incl) - its
now at 100%. 
   I'm including a new patch with this comment. No core algorithm changes, just some new tests.

Thanks for everything,
Colm

PS My next contribution should be a lot smoother :-)
                
> Add Match Rating Approach (MRA) phonetic algorithm encoder
> ----------------------------------------------------------
>
>                 Key: CODEC-161
>                 URL: https://issues.apache.org/jira/browse/CODEC-161
>             Project: Commons Codec
>          Issue Type: New Feature
>    Affects Versions: 1.6
>            Reporter: Colm Rice
>            Priority: Minor
>              Labels: newbie
>             Fix For: 1.8
>
>         Attachments: CODEC-161-MatchRatingApproach.patch, CODEC-161.patch, CODEC-161.patch,
CODEC-161.patch
>
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> I want to add MatchRatingApproach algorithm to the Lucene project via commons codec.
> What I have at the moment is a class called org.apache.lucene.analysis.phoenetic.MatchRatingApproach
implementing StringEncoder
> I have a pretty comprehensive test file located at: org.apache.lucene.analysis.phonetic.MatchRatingApproachTests
> It's not exactly existing pattern so I'm going to need a bit of advice here. Thanks!
Feel free to email.
> FYI: It my first contribution so be gentle :-)  C# is my native.
> I had incorrectly added this to Lucene solution as LUCENE-4494 but received some good
advice to move it to here. I'm doing that now.
> Reference: http://en.wikipedia.org/wiki/Match_rating_approach

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message