commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Seieroe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CONFIGURATION-515) Make private methods in PropertiesConfiguration.PropertiesWriter protected
Date Thu, 06 Dec 2012 03:16:58 GMT

    [ https://issues.apache.org/jira/browse/CONFIGURATION-515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13511050#comment-13511050
] 

Chris Seieroe commented on CONFIGURATION-515:
---------------------------------------------

For backwards compatibility with an existing config file, I don't want the values to be escaped.
For my purposes, I don't know which would be best to override without playing around with
it, but to be safe can we make escapeValue and handleBackslashs protected?
                
> Make private methods in PropertiesConfiguration.PropertiesWriter protected
> --------------------------------------------------------------------------
>
>                 Key: CONFIGURATION-515
>                 URL: https://issues.apache.org/jira/browse/CONFIGURATION-515
>             Project: Commons Configuration
>          Issue Type: Improvement
>    Affects Versions: 1.9
>            Reporter: Chris Seieroe
>            Priority: Minor
>
> I believe in version 1.7 the IOFactory was added to PropertiesConfiguration to make it
easy to replace the reader and writer. The default reader, PropertiesReader, does not have
any private methods. It has protected methods to set the property name, separator, and value.
The same cannot be said for the writer, PropertiesWriter. It has private methods like escapeKey,
escapeValue, handleBackslashs, and makeSingleLineValue. It makes extending this class difficult.
Can those private methods be turned protected?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message