Return-Path: X-Original-To: apmail-commons-issues-archive@minotaur.apache.org Delivered-To: apmail-commons-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 91695E92E for ; Tue, 20 Nov 2012 12:37:04 +0000 (UTC) Received: (qmail 16783 invoked by uid 500); 20 Nov 2012 12:37:04 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 16272 invoked by uid 500); 20 Nov 2012 12:36:58 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 16250 invoked by uid 99); 20 Nov 2012 12:36:58 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 20 Nov 2012 12:36:58 +0000 Date: Tue, 20 Nov 2012 12:36:58 +0000 (UTC) From: "Kazuki Hamasaki (JIRA)" To: issues@commons.apache.org Message-ID: <827011935.6419.1353415018169.JavaMail.jiratomcat@arcas> Subject: [jira] [Created] (LANG-857) Bad surrogate pair handling in the CharSequenceTranslator MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 Kazuki Hamasaki created LANG-857: ------------------------------------ Summary: Bad surrogate pair handling in the CharSequenceTranslator Key: LANG-857 URL: https://issues.apache.org/jira/browse/LANG-857 Project: Commons Lang Issue Type: Bug Components: lang.text.translate.* Affects Versions: 3.x Reporter: Kazuki Hamasaki Priority: Minor Attachments: CharSequenceTranslator_translate.patch I found that there is bad surrogate pair handling in the CharSequenceTranslator This is a simple test case for this problem. \uD83D\uDE30 is a surrogate pair. {code:java} @Test public void testEscapeSurrogatePairs() throws Exception { assertEquals("\uD83D\uDE30", StringEscapeUtils.escapeCsv("\uD83D\uDE30")); } {code} You'll get the exception as shown below. {code} java.lang.StringIndexOutOfBoundsException: String index out of range: 2 at java.lang.String.charAt(String.java:658) at java.lang.Character.codePointAt(Character.java:4668) at org.apache.commons.lang3.text.translate.CharSequenceTranslator.translate(CharSequenceTranslator.java:95) at org.apache.commons.lang3.text.translate.CharSequenceTranslator.translate(CharSequenceTranslator.java:59) at org.apache.commons.lang3.StringEscapeUtils.escapeCsv(StringEscapeUtils.java:556) {code} Patch attached, the method affected: # public final void translate(CharSequence input, Writer out) throws IOException -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira