Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Date: Wed, 14 Nov 2012 13:06:13 +0000 (UTC)
From: "Luc Maisonobe (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Message-ID: <1830183185.113658.1352898373594.JavaMail.jiratomcat@arcas>
In-Reply-To: <1970044595.91950.1352473693117.JavaMail.jiratomcat@arcas>
Subject: [jira] [Commented] (MATH-894) Cleanup of "ResizableDoubleArray"
 ("o.a.c.m.util")
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/MATH-894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497075#comment-13497075 ] 

Luc Maisonobe commented on MATH-894:
------------------------------------

bq. Shall we make the "expansionFactor", "contractionCriteria"[1] and "expansionMode" fields "final" (and hence deprecate the corresponding setters)?

Yes, I think so (and I also agree with the name change).
                
> Cleanup of "ResizableDoubleArray" ("o.a.c.m.util")
> --------------------------------------------------
>
>                 Key: MATH-894
>                 URL: https://issues.apache.org/jira/browse/MATH-894
>             Project: Commons Math
>          Issue Type: Improvement
>    Affects Versions: 3.0
>            Reporter: Gilles
>            Assignee: Gilles
>            Priority: Minor
>             Fix For: 3.1, 4.0
>
>
> Method "addElement" should not call "contract()", as it will almost always make the storage array shrink on the first call since it will be considered "too big" (for just storing one element).
> See discussion about this change in MATH-757.
> Miscellaneous code modifications are also proposed in order to improve encapsulation.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira