From issues-return-30689-apmail-commons-issues-archive=commons.apache.org@commons.apache.org Wed Nov 14 16:02:14 2012 Return-Path: X-Original-To: apmail-commons-issues-archive@minotaur.apache.org Delivered-To: apmail-commons-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E6184DCA2 for ; Wed, 14 Nov 2012 16:02:14 +0000 (UTC) Received: (qmail 76279 invoked by uid 500); 14 Nov 2012 16:02:14 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 75897 invoked by uid 500); 14 Nov 2012 16:02:13 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 75802 invoked by uid 99); 14 Nov 2012 16:02:12 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 14 Nov 2012 16:02:12 +0000 Date: Wed, 14 Nov 2012 16:02:12 +0000 (UTC) From: "Gilles (JIRA)" To: issues@commons.apache.org Message-ID: <737989622.114206.1352908932486.JavaMail.jiratomcat@arcas> In-Reply-To: <1970044595.91950.1352473693117.JavaMail.jiratomcat@arcas> Subject: [jira] [Commented] (MATH-894) Cleanup of "ResizableDoubleArray" ("o.a.c.m.util") MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/MATH-894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497177#comment-13497177 ] Gilles commented on MATH-894: ----------------------------- I also find it slightly odd that the "expansionFactor" and "contractionCriteria" are "float"s and not "double"s. > Cleanup of "ResizableDoubleArray" ("o.a.c.m.util") > -------------------------------------------------- > > Key: MATH-894 > URL: https://issues.apache.org/jira/browse/MATH-894 > Project: Commons Math > Issue Type: Improvement > Affects Versions: 3.0 > Reporter: Gilles > Assignee: Gilles > Priority: Minor > Fix For: 3.1, 4.0 > > Attachments: MATH-894.patch > > > Method "addElement" should not call "contract()", as it will almost always make the storage array shrink on the first call since it will be considered "too big" (for just storing one element). > See discussion about this change in MATH-757. > Miscellaneous code modifications are also proposed in order to improve encapsulation. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira