From issues-return-30655-apmail-commons-issues-archive=commons.apache.org@commons.apache.org Tue Nov 13 15:30:14 2012 Return-Path: X-Original-To: apmail-commons-issues-archive@minotaur.apache.org Delivered-To: apmail-commons-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B1718D60D for ; Tue, 13 Nov 2012 15:30:14 +0000 (UTC) Received: (qmail 64665 invoked by uid 500); 13 Nov 2012 15:30:14 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 64488 invoked by uid 500); 13 Nov 2012 15:30:13 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 64443 invoked by uid 99); 13 Nov 2012 15:30:12 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 Nov 2012 15:30:12 +0000 Date: Tue, 13 Nov 2012 15:30:12 +0000 (UTC) From: "Gilles (JIRA)" To: issues@commons.apache.org Message-ID: <2030479800.108197.1352820612234.JavaMail.jiratomcat@arcas> In-Reply-To: <1970044595.91950.1352473693117.JavaMail.jiratomcat@arcas> Subject: [jira] [Commented] (MATH-894) Spurious method call in "ResizableDoubleArray" ("o.a.c.m.util") MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/MATH-894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13496253#comment-13496253 ] Gilles commented on MATH-894: ----------------------------- bq. Removing the reallocation leaves the internal array at whatever size it was when clear was invoked. As it is now, it's a feature! Previously, "clear" was, for all purposes, synonymous to creating a new object. And when it comes to a user wanting to free resources, that's what he should do (creating a new object). I think that keeping the size is more useful since it could spare a series of reallocation/copying which might likely occur when the same array is reused (e.g. in a loop). I'll update the Javadoc. > Spurious method call in "ResizableDoubleArray" ("o.a.c.m.util") > --------------------------------------------------------------- > > Key: MATH-894 > URL: https://issues.apache.org/jira/browse/MATH-894 > Project: Commons Math > Issue Type: Improvement > Affects Versions: 3.0 > Reporter: Gilles > Assignee: Gilles > Priority: Minor > Fix For: 3.1 > > > Method "addElement" should not call "contract()", as it will almost always make the storage array shrink on the first call since it will be considered "too big" (for just storing one element). > See discussion about this change in MATH-757. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira