[ https://issues.apache.org/jira/browse/IO-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13501655#comment-13501655
]
Charles Honton commented on IO-357:
-----------------------------------
To allow calling Threads to know Tailer was stopped by interruption, use both options 2 and
3 from above:
@@ -360,6 +360,7 @@
try {
Thread.sleep(delayMillis);
} catch (InterruptedException e) {
+ stop();
+ Thread.currentThread().interrupt();
}
} else {
// The current position in the file
@@ -425,6 +426,7 @@
try {
Thread.sleep(delayMillis);
} catch (InterruptedException e) {
+ stop();
+ Thread.currentThread().interrupt();
}
> Tailer: Interruption while sleeping is silently ignored
> -------------------------------------------------------
>
> Key: IO-357
> URL: https://issues.apache.org/jira/browse/IO-357
> Project: Commons IO
> Issue Type: Bug
> Components: Streams/Writers
> Affects Versions: 2.4
> Reporter: Morten Hattesen
>
> The implementation of org.apache.commons.io.input.Tailer silently ignores interruptions
while sleeping (in two places).
> Source snippet:
> {code}
> 360 try {
> 361 Thread.sleep(delayMillis);
> 362 } catch (InterruptedException e) {
> 363 }
> ...
> 425 try {
> 426 Thread.sleep(delayMillis);
> 427 } catch (InterruptedException e) {
> 428 }
> {code}
> This is an inappropriate behavior, since it prevents controlled shutdown by a container.
> This may be rectified in one of these ways:
> # Declare the method as "throws InterruptedException" and re-throw the InterruptedException,
after possibly performing come cleanup, or removing the catch clause entirely. This will ensure
that a thread interruption (possibly caused by the forced shutdown by a container) will cause
processing to stop, and shutdown to proceed. Problem: Requires backwards incompatible change
to method signature.
> # Treat an interrupt as an alternate way of signalling the Tailer to stop, by calling
{{stop()}} in the catch clause.
> # Reassert the interrupted state of the thread by calling {{Thread.currentThread.interrupt()}}
to be able to detect the interruption at a later stage.
> For reference, please refer to these resources about handling thread interruption:
> * http://www.ibm.com/developerworks/java/library/j-jtp05236/index.html
> * Java Concurrency in Practice http://www.javaconcurrencyinpractice.com/
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
|