commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Morten Hattesen (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (IO-357) Tailer: Interruption while sleeping is silently ignored
Date Wed, 21 Nov 2012 02:04:58 GMT

    [ https://issues.apache.org/jira/browse/IO-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13501648#comment-13501648
] 

Morten Hattesen edited comment on IO-357 at 11/21/12 2:03 AM:
--------------------------------------------------------------

Having had another look at the code, you might also consider simply removing the two {{InterruptedException}}
catch blocks, letting the surrounding catch block handle the {{InterruptException}}. That
would exit the {{while}} loop, not requiring a call to {{stop()}}, and notifying the listener
about the interruption:

{code}
435	        } catch (Exception e) {
436	            // Handles InterruptedException, too
437	            listener.handle(e);
438	
439	        } finally {
440	            IOUtils.closeQuietly(reader);
441	        }
{code}

As always, the code is complete, when there is no more code to be removed ;)
 
                
      was (Author: mortenh):
    Having had another look at the code, you might also consider simply removing the two {{InterruptedException}}
catch blocks, letting the existing catch block handle the {{InterruptException}}. That would
exit the {{while}} loop, not requiring a call to {{stop()}}, and notifying the listener about
the interruption:

{code}
435	        } catch (Exception e) {
436	            // Handles InterruptedException, too
437	            listener.handle(e);
438	
439	        } finally {
440	            IOUtils.closeQuietly(reader);
441	        }
{code}

As always, the code is complete, when there is no more code to be removed ;)
 
                  
> Tailer: Interruption while sleeping is silently ignored
> -------------------------------------------------------
>
>                 Key: IO-357
>                 URL: https://issues.apache.org/jira/browse/IO-357
>             Project: Commons IO
>          Issue Type: Bug
>          Components: Streams/Writers
>    Affects Versions: 2.4
>            Reporter: Morten Hattesen
>
> The implementation of org.apache.commons.io.input.Tailer silently ignores interruptions
while sleeping (in two places).
> Source snippet:
> {code}
> 360	                    try {
> 361	                        Thread.sleep(delayMillis);
> 362	                    } catch (InterruptedException e) {
> 363	                    }
> ...
> 425	                try {
> 426	                    Thread.sleep(delayMillis);
> 427	                } catch (InterruptedException e) {
> 428	                }
> {code}
> This is an inappropriate behavior, since it prevents controlled shutdown by a container.
> This may be rectified in one of these ways:
> # Declare the method as "throws InterruptedException" and re-throw the InterruptedException,
after possibly performing come cleanup, or removing the catch clause entirely. This will ensure
that a thread interruption (possibly caused by the forced shutdown by a container) will cause
processing to stop, and shutdown to proceed. Problem: Requires backwards incompatible change
to method signature.
> # Treat an interrupt as an alternate way of signalling the Tailer to stop, by calling
{{stop()}} in the catch clause.
> # Reassert the interrupted state of the thread by calling {{Thread.currentThread.interrupt()}}
to be able to detect the interruption at a later stage.
> For reference, please refer to these resources about handling thread interruption:
> * http://www.ibm.com/developerworks/java/library/j-jtp05236/index.html
> * Java Concurrency in Practice http://www.javaconcurrencyinpractice.com/

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message