commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jared Becksfort (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MATH-817) Multivariate Normal Mixture Model Fitting by Expectation Maximization
Date Mon, 12 Nov 2012 15:31:12 GMT

    [ https://issues.apache.org/jira/browse/MATH-817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13495336#comment-13495336
] 

Jared Becksfort commented on MATH-817:
--------------------------------------

Most of these I can address and resubmit. If I have questions I will let you know.

The "catch (Exception e)" is used because multiple exception types will be consistently thrown,
and any time any exception is thrown, the run should reinitialize and restart. If there are
more specific exceptions to handle, they can be added before this one.

Regarding whether this class should be changed to handle all MixtureMultivariateRealDistributions:
there would be some utility in that, but I don't know that it would be straightforward to
implement. Differences in parameters among multivariate distributions may complicate things,
and initialization would be different for most of them. If other multivariate distributions
are eventually added, and it makes sense to combine their fitting into a single class, this
class could still exist as a way to automatically initialize multivariate normal mixture parameters
based on the data, and then it could use the new combined fitter class.

Hopefully whatever code format problems are in the files can be fixed by a CM code formatter.
                
> Multivariate Normal Mixture Model Fitting by Expectation Maximization
> ---------------------------------------------------------------------
>
>                 Key: MATH-817
>                 URL: https://issues.apache.org/jira/browse/MATH-817
>             Project: Commons Math
>          Issue Type: New Feature
>            Reporter: Jared Becksfort
>            Priority: Minor
>         Attachments: AbstractMultivariateRealDistribution.java.patch, MixtureMultivariateRealDistribution.java.patch,
MultivariateNormalDistribution.java.patch, MultivariateNormalMixtureExpectationMaximizationFitter.java,
MultivariateNormalMixtureExpectationMaximizationFitterTest.java
>
>   Original Estimate: 1m
>  Remaining Estimate: 1m
>
> I will submit a class for fitting Multivariate Normal Mixture Models using Expectation
Maximization.
> > Hello,
> >
> > I have implemented some classes for multivariate Normal distributions, multivariate
normal mixture models, and an expectation maximization fitting class for the mixture model.
 I would like to submit it to Apache Commons Math.  I still have some touching up to do so
that they fit the style guidelines and implement the correct interfaces.  Before I do so,
I thought I would at least ask if the developers of the project are interested in me submitting
them.
> >
> > Thanks,
> > Jared Becksfort
> Dear Jared,
> Yes, that would be very nice to have such an addition! Remember to also include unit
tests (refer to the current ones for examples). The best would be to split a submission up
into multiple minor ones, each covering a natural submission (e.g. multivariate Normal distribution
in one submission), and create an issue as described at http://commons.apache.org/math/issue-tracking.html
.
> If you run into any problems, please do not hesitate to ask on this mailing list.
> Cheers, Mikkel.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message