commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Phil Steitz (JIRA)" <>
Subject [jira] [Commented] (MATH-894) Cleanup of "ResizableDoubleArray" ("o.a.c.m.util")
Date Wed, 14 Nov 2012 23:36:13 GMT


Phil Steitz commented on MATH-894:

Changing names or removing private fields does not break compatibility.  What *has* to remain
is the protected setter that would do nothing.  This is a little smelly and really does point
to the fact that maybe the change to clear() resulting in the field doing nothing should be
pushed to 4.0.  As long as you leave the float-valued getters and setters in, adding double
versions will not break compat, but will create a mess that I would personally rather see
pushed to 4.0 (if ever - it does not bother me that the current fields are floats).
> Cleanup of "ResizableDoubleArray" ("o.a.c.m.util")
> --------------------------------------------------
>                 Key: MATH-894
>                 URL:
>             Project: Commons Math
>          Issue Type: Improvement
>    Affects Versions: 3.0
>            Reporter: Gilles
>            Assignee: Gilles
>            Priority: Minor
>             Fix For: 3.1, 4.0
>         Attachments: MATH-894.patch
> Method "addElement" should not call "contract()", as it will almost always make the storage
array shrink on the first call since it will be considered "too big" (for just storing one
> See discussion about this change in MATH-757.
> Miscellaneous code modifications are also proposed in order to improve encapsulation.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

View raw message