Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Date: Tue, 9 Oct 2012 01:56:03 +0000 (UTC)
From: "Matt Benson (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Message-ID: <707652544.12314.1349747763101.JavaMail.jiratomcat@arcas>
In-Reply-To: <52920154.141491.1348873627529.JavaMail.jiratomcat@arcas>
Subject: [jira] [Commented] (LANG-839) ArrayUtils removeElements methods use
 unnecessary HashSet
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/LANG-839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13472056#comment-13472056 ] 

Matt Benson commented on LANG-839:
----------------------------------

Nice!
                
> ArrayUtils removeElements methods use unnecessary HashSet
> ---------------------------------------------------------
>
>                 Key: LANG-839
>                 URL: https://issues.apache.org/jira/browse/LANG-839
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: lang.*
>    Affects Versions: 3.1
>            Reporter: Sebb
>            Priority: Minor
>             Fix For: 3.2
>
>         Attachments: LANG-839.patch
>
>
> The removeElements() methods use a HashSet to collect the indexes that need removing.
> This requires creating Integer objects for each index, and the HashSet then has to be converted into an int[] array.
> It would be more efficient to store the entries in an actual int[] array.
> The maximum size of this is the length of the values array (or the length of the input array if that is shorter).
> The array must be truncated before calling the private removeAll() method; this can be done with Arrays.copyOf(x[], length).
> However, if the arrays are very large, and most of the values do not appear in the input, this might result in using more memory than the HashSet implementation.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira