Return-Path: X-Original-To: apmail-commons-issues-archive@minotaur.apache.org Delivered-To: apmail-commons-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EF5D5D925 for ; Wed, 31 Oct 2012 21:55:12 +0000 (UTC) Received: (qmail 85281 invoked by uid 500); 31 Oct 2012 21:55:12 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 85187 invoked by uid 500); 31 Oct 2012 21:55:12 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 85171 invoked by uid 99); 31 Oct 2012 21:55:12 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 31 Oct 2012 21:55:12 +0000 Date: Wed, 31 Oct 2012 21:55:12 +0000 (UTC) From: "Colm Rice (JIRA)" To: issues@commons.apache.org Message-ID: <655105511.53306.1351720512470.JavaMail.jiratomcat@arcas> In-Reply-To: <1410606912.26670.1351155253834.JavaMail.jiratomcat@arcas> Subject: [jira] [Commented] (CODEC-161) Add phonetic algorithm Match Rating Approach (MRA) to the commons codec MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CODEC-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13488272#comment-13488272 ] Colm Rice commented on CODEC-161: --------------------------------- Hi Thomas/Gary, Thanks a mill for the code review. I'm such a newbie I was actually unaware of the trunk checkstyle config :-) Nice! Will use going forward. BTW, I'm using the Eclipse IDE - let me know of any other tips/plugins that are useful. C# is my native, so I'm crossing over a bit into Java. I will of course re-factor your suggestions. TBC, Colm > Add phonetic algorithm Match Rating Approach (MRA) to the commons codec > ----------------------------------------------------------------------- > > Key: CODEC-161 > URL: https://issues.apache.org/jira/browse/CODEC-161 > Project: Commons Codec > Issue Type: New Feature > Affects Versions: 1.6 > Reporter: Colm Rice > Priority: Minor > Labels: newbie > Attachments: CODEC-161-MatchRatingApproach.patch > > Original Estimate: 168h > Remaining Estimate: 168h > > I want to add MatchRatingApproach algorithm to the Lucene project via commons codec. > What I have at the moment is a class called org.apache.lucene.analysis.phoenetic.MatchRatingApproach implementing StringEncoder > I have a pretty comprehensive test file located at: org.apache.lucene.analysis.phonetic.MatchRatingApproachTests > It's not exactly existing pattern so I'm going to need a bit of advice here. Thanks! Feel free to email. > FYI: It my first contribution so be gentle :-) C# is my native. > I had incorrectly added this to Lucene solution as LUCENE-4494 but received some good advice to move it to here. I'm doing that now. > Reference: http://en.wikipedia.org/wiki/Match_rating_approach -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira