Return-Path: X-Original-To: apmail-commons-issues-archive@minotaur.apache.org Delivered-To: apmail-commons-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 348DA9259 for ; Fri, 5 Oct 2012 09:27:15 +0000 (UTC) Received: (qmail 59931 invoked by uid 500); 5 Oct 2012 09:27:14 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 59113 invoked by uid 500); 5 Oct 2012 09:27:06 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 59045 invoked by uid 99); 5 Oct 2012 09:27:03 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Oct 2012 09:27:03 +0000 Date: Fri, 5 Oct 2012 09:27:03 +0000 (UTC) From: "Sebb (JIRA)" To: issues@commons.apache.org Message-ID: <2031158279.46.1349429223497.JavaMail.jiratomcat@arcas> In-Reply-To: <440719665.3572.1349399387285.JavaMail.jiratomcat@arcas> Subject: [jira] [Commented] (LANG-841) Add StringUtils replaceAllPatternDotAll and removeAllPatternDotAll MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/LANG-841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13470193#comment-13470193 ] Sebb commented on LANG-841: --------------------------- JIRA description too terse - please explain purpose don't have to read patch. Also, DOTALL is not an obvious name. Might be worth stating in Javadoc that DOTALL means the same as Perl 'single-line' mode, i.e. removeAllPatternDotAll(source, regex, replacement) has the same effect as source.replaceAll("(?s)"+regex, replacement); > Add StringUtils replaceAllPatternDotAll and removeAllPatternDotAll > ------------------------------------------------------------------ > > Key: LANG-841 > URL: https://issues.apache.org/jira/browse/LANG-841 > Project: Commons Lang > Issue Type: New Feature > Components: lang.* > Environment: Apache Maven 3.0.4 (r1232337; 2012-01-17 03:44:56-0500) > Maven home: C:\Java\apache-maven-3.0.4\bin\.. > Java version: 1.6.0_35, vendor: Sun Microsystems Inc. > Java home: C:\Program Files\Java\jdk1.6.0_35\jre > Default locale: en_US, platform encoding: Cp1252 > OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows" > Reporter: Gary D. Gregory > Attachments: lang-841.diff > > > Patch attached. > Feedback? Better method names? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira