From issues-return-29750-apmail-commons-issues-archive=commons.apache.org@commons.apache.org Mon Oct 1 09:27:14 2012 Return-Path: X-Original-To: apmail-commons-issues-archive@minotaur.apache.org Delivered-To: apmail-commons-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 05AFADF7F for ; Mon, 1 Oct 2012 09:27:14 +0000 (UTC) Received: (qmail 39440 invoked by uid 500); 1 Oct 2012 09:27:13 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 38988 invoked by uid 500); 1 Oct 2012 09:27:09 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 38844 invoked by uid 99); 1 Oct 2012 09:27:07 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Oct 2012 09:27:07 +0000 Date: Mon, 1 Oct 2012 20:27:07 +1100 (NCT) From: "Gilles (JIRA)" To: issues@commons.apache.org Message-ID: <422107329.147344.1349083627717.JavaMail.jiratomcat@arcas> In-Reply-To: <2086244282.133911.1348755607441.JavaMail.jiratomcat@arcas> Subject: [jira] [Commented] (MATH-871) math3 SecantSolver can return Double.INFINITE MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/MATH-871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466711#comment-13466711 ] Gilles commented on MATH-871: ----------------------------- bq. In SecantSolver.doSolve(), I had a situation in which f0 and f1, from computeObjectiveValue() on lines 77 & 78, were the same value. My first comment was a bit hasty. "f0" and f1" cannot have the same value, as that would mean that there is no bracketing, a condition that is checked and, if not satisfied, raises an exception. The line numbers you refer to seems to indicate that I do not look at the same code: Did you test with a recent snapshot of the library? Alternately, please provide the use case. > math3 SecantSolver can return Double.INFINITE > --------------------------------------------- > > Key: MATH-871 > URL: https://issues.apache.org/jira/browse/MATH-871 > Project: Commons Math > Issue Type: Bug > Affects Versions: 3.0 > Reporter: Anthony Maidment > Priority: Minor > > In SecantSolver.doSolve(), I had a situation in which f0 and f1, from computeObjectiveValue() on lines 77 & 78, were the same value. > Then when it calculates the next appromixation at line 101: > final double x = x1 - ((f1 * (x1 - x0)) / (f1 - f0)); > The denominator is then zero, and the next approximation is Double.INFINITE. > I was able to work around this in this particular instance by relaxing the accuracy requirements of the solver, although I haven't yet fully tested the downstream implications of this change. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira