commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gilles (JIRA)" <>
Subject [jira] [Created] (MATH-887) "AbstractLeastSquares" cleanup
Date Tue, 30 Oct 2012 01:04:12 GMT
Gilles created MATH-887:

             Summary: "AbstractLeastSquares"  cleanup
                 Key: MATH-887
             Project: Commons Math
          Issue Type: Task
    Affects Versions: 3.0
            Reporter: Gilles
            Assignee: Gilles
            Priority: Minor
             Fix For: 3.1, 4.0

Class "AbstractLeastSquares" (in package "o.a.c.m.optimization.general") has a lot of "protected"
fields that are modified by its subclasses (e.g. "LevenbergMarquardt"). This decreases encapsulation
which in turn makes the code more difficult to understand and modify.
I propose to deprecate (in 3.1) and remove or make "private" (in 4.0) all fields that could
be hidden or should be modified through setter methods.

Part of the code could also be more readable (and self-documenting) by making use of higher-level
constructs such as "RealMatrix" rather than using explicit loops.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

View raw message