commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sébastien Brisard (JIRA) <j...@apache.org>
Subject [jira] [Commented] (MATH-778) Dfp Dfp.multiply(int x) does not comply with the general contract FieldElement.multiply(int n)
Date Sun, 21 Oct 2012 09:08:14 GMT

    [ https://issues.apache.org/jira/browse/MATH-778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13480931#comment-13480931
] 

Sébastien Brisard commented on MATH-778:
----------------------------------------

Seems good to me too. Using shift-right operations would result in faster implementations.
I remember having tried that at the time I created this issue, but it seems to me I met with
an issue, I can't remember what...
So for the time being, let's stick with this patch, and once we get some time, we can look
into optimizations.
                
> Dfp Dfp.multiply(int x) does not comply with the general contract FieldElement.multiply(int
n)
> ----------------------------------------------------------------------------------------------
>
>                 Key: MATH-778
>                 URL: https://issues.apache.org/jira/browse/MATH-778
>             Project: Commons Math
>          Issue Type: Bug
>    Affects Versions: 3.0
>            Reporter: Sébastien Brisard
>            Assignee: Sébastien Brisard
>             Fix For: 3.1
>
>         Attachments: MATH-778.patch
>
>
> In class {{org.apache.commons.math3.Dfp}},  the method {{multiply(int n)}} is limited
to {{0 <= n <= 9999}}. This is not consistent with the general contract of {{FieldElement.multiply(int
n)}}, where there should be no limitation on the values of {{n}}.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message