commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gary D. Gregory (JIRA)" <>
Subject [jira] [Commented] (VFS-440) [SFTP] Stream (e.g. netcat) proxy for Sftp file system (aka ProxyCommand)
Date Tue, 23 Oct 2012 04:45:11 GMT


Gary D. Gregory commented on VFS-440:

Thank you for the patch and sorry it has taken me so long to take a look.

I just started to review the patch, but it would be helpful if it did NOT contain ANY formatting
changes. That makes the while process take longer. So, if you can attach a patch that contains
the semantic changes only, this will all go faster.

One thing that I noticed in private static void connect(String name, final InputStream in,
final OutputStream out, final ExitCallback callback):

+                catch (SshException ex)
+                {
+                }

That's probably not great unless I am missing something.

Also, do not hesitate to comment the code some more, that helps too :)

Thank you,
> [SFTP] Stream (e.g. netcat) proxy for Sftp file system (aka ProxyCommand)
> -------------------------------------------------------------------------
>                 Key: VFS-440
>                 URL:
>             Project: Commons VFS
>          Issue Type: Improvement
>            Reporter: Benjamin Piwowarski
>            Priority: Minor
>              Labels: proxy, sftp
>         Attachments: sftp-stream-proxy.diff
> What I propose is to add the possibility to connect to a remote SSH server through an
SSH connection stream (instead of an HTTP or SOCKS proxy). See for instance
> for a use case.
> This simulates a ProxyCommand where the command is run on a SSH host.
> The patch also contains a test for the new functionality. 
> Example of use (with the netcat command nc -q 0 HOSTNAME PORT)
> {code:java}
> builder.setProxyType(opts, SftpFileSystemConfigBuilder.PROXY_STREAM);
> builder.setProxyCommand(opts, SftpStreamProxy.NETCAT_COMMAND);
> builder.setProxyHost(opts, "");
> builder.setProxyPort(opts, 22);
> builder.setProxyOptions(opts, proxyOptions);
> {code}

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

View raw message