commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (LANG-833) ToStringBuilder should use StringBuilder
Date Tue, 16 Oct 2012 08:47:03 GMT

    [ https://issues.apache.org/jira/browse/LANG-833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13464619#comment-13464619
] 

Sebb edited comment on LANG-833 at 10/16/12 8:46 AM:
-----------------------------------------------------

bq. No cause for it. [i.e. StringBuffer]

StringBuffer may still be needed for synchronisation purposes.

Also if used in APIs, it may not be possible to change to StringBuilder without breaking compatibility.

But if it is possible to replace Buffer with Builder it would be sensible to do so.
                
      was (Author: sebb@apache.org):
    bq. No cause for it. [i.e. StringBuffer]

StringBuffer may still be needed for snchronisation purposes.

Also if used in APIs, it may not be possible to change to StringBuilder without breaking compatibility.

But if it is possible to replace Buffer with Builder it would be sensible to do so.
                  
> ToStringBuilder should use StringBuilder
> ----------------------------------------
>
>                 Key: LANG-833
>                 URL: https://issues.apache.org/jira/browse/LANG-833
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: lang.*
>    Affects Versions: 3.1
>            Reporter: Shevek
>
> Rewriting as lang3 but still using StringBuffer (synchronized) looks like a missed opportunity.
Please use StringBuilder.
> Suggest audit for uses of StringBuffer in lang3 overall. No cause for it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message